Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Stripe: Fix the Refunds stream missing data in Incremental sync mode #39138

Merged
merged 12 commits into from
Jun 6, 2024
Merged

🐛 Source Stripe: Fix the Refunds stream missing data in Incremental sync mode #39138

merged 12 commits into from
Jun 6, 2024

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Jun 5, 2024 •
edited
Loading

What

Resolving:

How

  • Added new event type: charge.refund.updated to Refunds stream incremental sync mode to retrieve the updated refunds
  • Changed the CreatedCursorIncrementalStripeStream to IncrementalStripeStream to be used for the Refunds stream and make the Refunds stream concurrent again
  • updated unit_tests to reflect the changes

User Impact

This is the breaking change since the cursor field has changed from created > updated. Resetting of the affected stream is required.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 3:13pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 5, 2024
@bazarnov bazarnov self-assigned this Jun 5, 2024
@bazarnov bazarnov marked this pull request as ready for review June 5, 2024 22:03
@bazarnov bazarnov requested a review from a team June 5, 2024 22:03
maxi297
maxi297 reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a breaking change? I'm asking because the state format is changing from {"created": 1717598674} to {"updated": 1717598674}

maxi297
maxi297 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptively approving given that this comment is addressed

@bazarnov bazarnov requested a review from maxi297 June 6, 2024 14:21
@octavia-squidington-iv octavia-squidington-iv requested a review from a team June 6, 2024 14:22
maxi297
maxi297 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval on the wording if you think this makes more sense

@bazarnov bazarnov merged commit 266169a into master Jun 6, 2024
30 of 31 checks passed
@bazarnov bazarnov deleted the baz/stripe/fix-refunds-stream branch June 6, 2024 15:28
@michelgalle michelgalle mentioned this pull request Jul 17, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxi297 maxi297 maxi297 approved these changes

Assignees

@bazarnov bazarnov

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bazarnov @maxi297 @octavia-squidington-iii